Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TR1 FMV player to libtrx and update TR2 to use it #1730

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Move TR1 FMV player to libtrx and update TR2 to use it #1730

merged 2 commits into from
Oct 21, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Oct 20, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1729.

Needs both TR1 and TR2 to be tested, particularly for potentially nasty scenarios like alt-tabbing, taking screenshots, or trying to use the console during playback. TR2 testing should also cover both software and hardware renderers, as well as fullscreen and windowed modes, since each has a significantly different implementation.

@rr- rr- added Enhancement Improvement of an existing feature TR2 TR1 labels Oct 20, 2024
@rr- rr- self-assigned this Oct 20, 2024
@rr- rr- requested review from a team as code owners October 20, 2024 20:33
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team October 20, 2024 20:33
@lahm86
Copy link
Collaborator

lahm86 commented Oct 21, 2024

TR1 looks fine, no issues there that I can see.

For TR2, I can hear the FMVs but see only a black screen.

@rr-
Copy link
Collaborator Author

rr- commented Oct 21, 2024

TR1 looks fine, no issues there that I can see.

For TR2, I can hear the FMVs but see only a black screen.

Thanks. Which rendering settings are you using?

@lahm86
Copy link
Collaborator

lahm86 commented Oct 21, 2024

TR1 looks fine, no issues there that I can see.
For TR2, I can hear the FMVs but see only a black screen.

Thanks. Which rendering settings are you using?

Sorry, I didn't provide more detail before. This is my current config. Changing to full screen, I can't run the game at all (I have a 1440p monitor, and changing the resolution to 1080 doesn't help there - my guess is that's a DirectX issue which the older games suffer from).

image

@rr-
Copy link
Collaborator Author

rr- commented Oct 21, 2024

@lahm86 can you please check now?

@lahm86
Copy link
Collaborator

lahm86 commented Oct 21, 2024

@lahm86 can you please check now?

Thanks, everything looks good. Tried alt-tabbing, alt-F4, console, shifting the window around and couldn't find any problems.

@aredfan
Copy link
Collaborator

aredfan commented Oct 21, 2024

TR1X and TR2X issue:

  • It's possible to open the console during FMVs but it isn't visible. This doesn't happen in the latest TR1X dev snapshot.

TR2X issues:

  • Fullscreen - the game crashes after the second intro FMV.

My setup:

Screenshot

@Richard-L
Copy link
Collaborator

I had thought FMVs being invisible in TR2X is just a normal consequence of the game not being fully decompiled yet, and according issues on that wouldn't be welcome. But I see you've been working on FMVs, so maybe I'm just slow to connect the dots hah.

When you say "try now", is it possible for me to go somewhere within Github to update a windows build for myself somehow? Can also discuss this on discord.

@rr-
Copy link
Collaborator Author

rr- commented Oct 21, 2024

@aredfan addressed both issues.

@Richard-L you can find PR builds in the build details → details (any job) → summary → relevant zip files.

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aredfan addressed both issues.

Both issues are fixed, thank you. 👍

@rr- rr- merged commit fb21aed into develop Oct 21, 2024
5 checks passed
@rr- rr- deleted the fmv branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1 TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve TR2 FMV cutscene rendering
4 participants