-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TR1 FMV player to libtrx and update TR2 to use it #1730
Conversation
TR1 looks fine, no issues there that I can see. For TR2, I can hear the FMVs but see only a black screen. |
Thanks. Which rendering settings are you using? |
Sorry, I didn't provide more detail before. This is my current config. Changing to full screen, I can't run the game at all (I have a 1440p monitor, and changing the resolution to 1080 doesn't help there - my guess is that's a DirectX issue which the older games suffer from). |
@lahm86 can you please check now? |
Thanks, everything looks good. Tried alt-tabbing, alt-F4, console, shifting the window around and couldn't find any problems. |
I had thought FMVs being invisible in TR2X is just a normal consequence of the game not being fully decompiled yet, and according issues on that wouldn't be welcome. But I see you've been working on FMVs, so maybe I'm just slow to connect the dots hah. When you say "try now", is it possible for me to go somewhere within Github to update a windows build for myself somehow? Can also discuss this on discord. |
@aredfan addressed both issues. @Richard-L you can find PR builds in the build details → details (any job) → summary → relevant zip files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aredfan addressed both issues.
Both issues are fixed, thank you. 👍
Checklist
Description
Resolves #1729.
Needs both TR1 and TR2 to be tested, particularly for potentially nasty scenarios like alt-tabbing, taking screenshots, or trying to use the console during playback. TR2 testing should also cover both software and hardware renderers, as well as fullscreen and windowed modes, since each has a significantly different implementation.